Upgrade to Rails 7.2, Ruby 3.3; Increased RSpec test reliability #7559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi-herwana-nus
force-pushed
the
adi/rails-upgrade
branch
5 times, most recently
from
069fe1e
to
5f2878b
Compare
adi-herwana-nus
force-pushed
the
adi/rails-upgrade
branch
8 times, most recently
from
93127b6
to
709e53b
Compare
adi-herwana-nus
changed the title
adi-herwana-nus
force-pushed
the
adi/rails-upgrade
branch
3 times, most recently
from
4c42549
to
36eda2c
Compare
cysjonathan
requested changes
Oct 8, 2024
adi-herwana-nus
force-pushed
the
adi/rails-upgrade
branch
from
36eda2c
to
ccda2e8
Compare
added 5 commits
October 8, 2024 16:24
- removed unused rails_utils dependency - removed deprecated fixture_path config keys - updated database extension to sync with internal change
- migrated secret_key_base from Rails secrets to (encrypted) credentials - updated all enum declarations from deprecated keyword args to positional args - updated gem calculated_attributes to compatible self-maintained fork - updated third-party gems unread,active_record_upsert to compatible bleeding-edge commits - mock _default_attributes also for specs mocking load_schema (needed due to internal refactoring in 7.2) - set eager_load to true in all environments to ensure table_name overrides loaded - updated carrierwave to v3, amended relevant test case
- fix error due to tar files being frozen strings
- updated Keycloak config to allow user delete/overwrite from DB - refactored various tests/helper functions to phase out sleep stmts - improved handling of 'New Question' flow to account for page animations - added search queries to tests looking for objects in paginated lists - increased Capybara max wait time from 5s to 10s
- added missing translations from #7542 - migrated away from deprecated codecov gem
adi-herwana-nus
force-pushed
the
adi/rails-upgrade
branch
from
ccda2e8
to
ff3e296
Compare
cysjonathan
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.